Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to official redis-go client #1459

Merged
merged 1 commit into from
May 2, 2023

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented May 1, 2023

This client is now under the redis org. The previous client seems less maintained.

Summary

Release Note

Documentation

This client is now under the redis org.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper
Copy link
Contributor Author

Tested locally, submitted one entry to log, retrieved with search API

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Merging #1459 (4d76067) into main (059e097) will decrease coverage by 16.61%.
The diff coverage is 69.23%.

@@             Coverage Diff             @@
##             main    #1459       +/-   ##
===========================================
- Coverage   64.35%   47.75%   -16.61%     
===========================================
  Files          82       82               
  Lines        7873     7875        +2     
===========================================
- Hits         5067     3761     -1306     
- Misses       2159     3411     +1252     
- Partials      647      703       +56     
Flag Coverage Δ
e2etests 47.75% <69.23%> (+0.07%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/index.go 67.82% <50.00%> (-1.48%) ⬇️
pkg/api/api.go 68.23% <100.00%> (+3.94%) ⬆️

... and 40 files with indirect coverage changes

@lukehinds lukehinds merged commit baa14ce into sigstore:main May 2, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.1.0 milestone May 2, 2023
@haydentherapper haydentherapper deleted the redis-cli branch May 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants