Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove watcher script #1484

Merged
merged 2 commits into from
May 14, 2023
Merged

Remove watcher script #1484

merged 2 commits into from
May 14, 2023

Conversation

haydentherapper
Copy link
Contributor

@haydentherapper haydentherapper commented May 11, 2023

#1461 removes the need for the watcher script, now that they'll be persisted in Redis. This job has not been running in production for a year too, so we can remove the rekor-sth bucket.

Fixes #1001

Summary

Release Note

Documentation

now that they'll be persisted in Redis. This job has not been running in
production or staging for a year too, so we can remove the rekor-sth
bucket.

Fixes sigstore#1001

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@haydentherapper haydentherapper requested a review from a team as a code owner May 11, 2023 17:17
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #1484 (92c84e2) into main (3282e1a) will decrease coverage by 19.68%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1484       +/-   ##
===========================================
- Coverage   64.33%   44.65%   -19.68%     
===========================================
  Files          80       71        -9     
  Lines        7789     7065      -724     
===========================================
- Hits         5011     3155     -1856     
- Misses       2129     3571     +1442     
+ Partials      649      339      -310     
Flag Coverage Δ
e2etests ?
unittests 44.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 54 files with indirect coverage changes

Signed-off-by: Hayden B <hblauzvern@google.com>
@cpanato cpanato merged commit 55725b0 into sigstore:main May 14, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.1.0 milestone May 14, 2023
@haydentherapper haydentherapper deleted the remove-watcher branch May 14, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Remove watcher
3 participants