Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint errors, bump linter up to 1.52 #1485

Merged
merged 1 commit into from
May 13, 2023
Merged

Conversation

bobcallaway
Copy link
Member

No description provided.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested review from asraa, cpanato and a team as code owners May 12, 2023 23:17
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1485 (c8fa831) into main (3282e1a) will increase coverage by 0.11%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   64.33%   64.44%   +0.11%     
==========================================
  Files          80       80              
  Lines        7789     7780       -9     
==========================================
+ Hits         5011     5014       +3     
+ Misses       2129     2121       -8     
+ Partials      649      645       -4     
Flag Coverage Δ
e2etests 48.27% <42.85%> (+0.05%) ⬆️
unittests 44.73% <33.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/entries.go 64.87% <0.00%> (ø)
pkg/api/index.go 69.56% <0.00%> (ø)
pkg/api/public_key.go 28.57% <0.00%> (ø)
pkg/api/tlog.go 39.02% <0.00%> (ø)
pkg/types/cose/v0.0.1/entry.go 54.97% <0.00%> (ø)
pkg/types/test_util.go 0.00% <0.00%> (ø)
cmd/rekor-cli/app/state/state.go 65.38% <100.00%> (+3.56%) ⬆️
cmd/rekor-cli/app/upload.go 55.45% <100.00%> (+1.47%) ⬆️
cmd/rekor-cli/app/verify.go 57.62% <100.00%> (+1.42%) ⬆️
pkg/pki/minisign/minisign.go 75.83% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

@cpanato cpanato merged commit 7359299 into sigstore:main May 13, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.1.0 milestone May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants