Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client method to generate TLE struct #1498

Merged
merged 7 commits into from
May 25, 2023

Conversation

bobcallaway
Copy link
Member

@bobcallaway bobcallaway commented May 23, 2023

Summary

Adds helper method in github.com/sigstore/rekor/pkg/client to generate https://pkg.go.dev/github.com/sigstore/protobuf-specs@v0.1.0/gen/pb-go/rekor/v1#TransparencyLogEntry from an entry retrieved from a Rekor instance

Release Note

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner May 23, 2023 12:19
Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1498 (9be4166) into main (f1bdca8) will increase coverage by 20.27%.
The diff coverage is 77.94%.

@@             Coverage Diff             @@
##             main    #1498       +/-   ##
===========================================
+ Coverage   46.85%   67.13%   +20.27%     
===========================================
  Files          72       82       +10     
  Lines        7401     8392      +991     
===========================================
+ Hits         3468     5634     +2166     
+ Misses       3592     2089     -1503     
- Partials      341      669      +328     
Flag Coverage Δ
e2etests 48.51% <1.47%> (?)
unittests 47.86% <91.37%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/rekor-cli/app/format/wrap.go 40.62% <0.00%> (ø)
cmd/rekor-cli/app/get.go 49.66% <0.00%> (+47.60%) ⬆️
pkg/client/rekor_client.go 94.31% <96.29%> (+3.14%) ⬆️
cmd/rekor-cli/app/pflags.go 90.30% <100.00%> (ø)

... and 55 files with indirect coverage changes

pkg/client/rekor_client.go Show resolved Hide resolved
pkg/client/rekor_client.go Outdated Show resolved Hide resolved
cmd/rekor-cli/app/get.go Outdated Show resolved Hide resolved
pkg/client/rekor_client.go Show resolved Hide resolved
pkg/client/rekor_client.go Outdated Show resolved Hide resolved
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway
Copy link
Member Author

I'll make the CLI changes in a different PR

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@bobcallaway bobcallaway merged commit 795a236 into sigstore:main May 25, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.1.0 milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants