Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: Add utility to create structured jar bytes #1548

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

AdamKorcz
Copy link
Contributor

Summary

  • Adds a utility to create structured jar bytes.
  • Change the cleanup return value of CreateProps to be an array of funcs instead of a single func.
  • Add name parameter to CreateProps.
  • Bump github.com/AdamKorcz/go-fuzz-headers-1

This only affects the FuzzJarCreateProposedEntry fuzzer.

Release Note

Documentation

@AdamKorcz AdamKorcz requested review from asraa, bobcallaway and a team as code owners June 18, 2023 17:48
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #1548 (b09eef9) into main (beae36f) will increase coverage by 18.60%.
The diff coverage is n/a.

❗ Current head b09eef9 differs from pull request most recent head 44e23f8. Consider uploading reports for the commit 44e23f8 to get more accurate results

@@             Coverage Diff             @@
##             main    #1548       +/-   ##
===========================================
+ Coverage   48.37%   66.97%   +18.60%     
===========================================
  Files          83       83               
  Lines        8389     8406       +17     
===========================================
+ Hits         4058     5630     +1572     
+ Misses       3525     2101     -1424     
+ Partials      806      675      -131     
Flag Coverage Δ
e2etests 48.31% <ø> (-0.07%) ⬇️
unittests 47.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 49 files with indirect coverage changes

bobcallaway
bobcallaway previously approved these changes Jun 23, 2023
@bobcallaway
Copy link
Member

@AdamKorcz can you quickly rebase this so we can merge it? thanks!

Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: AdamKorcz <adam@adalogics.com>
@bobcallaway bobcallaway enabled auto-merge (squash) June 28, 2023 16:10
@bobcallaway bobcallaway merged commit aacc6ae into sigstore:main Jun 28, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants