chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml
#1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1558 +/- ##
===========================================
+ Coverage 47.78% 66.90% +19.11%
===========================================
Files 75 83 +8
Lines 7774 8406 +632
===========================================
+ Hits 3715 5624 +1909
+ Misses 3699 2105 -1594
- Partials 360 677 +317
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobcallaway
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
github.com/ghodss/yamlpackage is no longer being actively maintained.sigs.k8s.io/yamlis a permanent fork ofgithub.com/ghodss/yaml, which is actively maintained by Kubernetes SIG and widely used in K8s projects.The notable change is that
github.com/ghodss/yamlusesgopkg.in/yaml.v2 v2.2.2, whilesigs.k8s.io/yamlusesgopkg.in/yaml.v2 v2.4.0. You can see the changes between the two versions here: v2.2.2...v2.4.0, which mostly consists of bug fixes.Release Note
Replace unmaintained
github.com/ghodss/yamldependency withsigs.k8s.io/yaml.Documentation