Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds redis auth. #1627

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: adds redis auth. #1627

merged 1 commit into from
Oct 31, 2023

Conversation

ianhundere
Copy link
Contributor

@ianhundere ianhundere commented Aug 9, 2023

Summary

This PR enables auth using the redis options struct to include a flag for a password/auth.

Closes #1613

Release Note

  • Adds Redis Authentication

Documentation

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #1627 (6799549) into main (3bf6253) will increase coverage by 0.04%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
+ Coverage   66.51%   66.55%   +0.04%     
==========================================
  Files          90       90              
  Lines        9048     9051       +3     
==========================================
+ Hits         6018     6024       +6     
+ Misses       2300     2298       -2     
+ Partials      730      729       -1     
Flag Coverage Δ
e2etests 48.12% <100.00%> (+0.01%) ⬆️
unittests 47.60% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/rekor-server/app/root.go 63.88% <100.00%> (+0.33%) ⬆️
pkg/api/api.go 69.23% <100.00%> (+0.26%) ⬆️
pkg/indexstorage/indexstorage.go 66.66% <100.00%> (ø)
pkg/indexstorage/redis/redis.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ianhundere ianhundere closed this Aug 22, 2023
@ianhundere ianhundere reopened this Aug 22, 2023
@ianhundere ianhundere marked this pull request as ready for review October 27, 2023 16:29
@ianhundere ianhundere requested a review from a team as a code owner October 27, 2023 16:29
pkg/api/api.go Outdated Show resolved Hide resolved
@haydentherapper
Copy link
Contributor

@bobcallaway Is the issue here that we need to set up go before CI is run?

@bobcallaway
Copy link
Member

looks like a go mod tidy is needed, as well as an update to docker-compose.test.yml to include the password

Signed-off-by: ianhundere <138915+ianhundere@users.noreply.github.com>
@ianhundere
Copy link
Contributor Author

looks like a go mod tidy is needed, as well as an update to docker-compose.test.yml to include the password

thanks, i ran go mod tidy and added a redis pw to docker-compose.test.yml.

@bobcallaway bobcallaway merged commit 9f49d7b into sigstore:main Oct 31, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Oct 31, 2023
@ianhundere ianhundere deleted the adds_redis_authentication branch October 31, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add redis auth
3 participants