Extract all subjects from SANs for x509 verifier #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation is also handled during certificate creation, so the contents of the x509 cert should follow rfc5280. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov Report
@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 66.90% 66.89% -0.01%
==========================================
Files 83 83
Lines 8452 8441 -11
==========================================
- Hits 5655 5647 -8
+ Misses 2118 2116 -2
+ Partials 679 678 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobcallaway
approved these changes
Aug 11, 2023
lukehinds
approved these changes
Aug 13, 2023
cpanato
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously in Identities(), but was dropped during the refactor.
Validation is also handled during certificate creation, so the contents of the x509 cert should follow rfc5280.
Summary
Release Note
Documentation