Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass transient errors through retrieveLogEntry #1653

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

bobcallaway
Copy link
Member

Fixes #1652

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner August 29, 2023 22:17
Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #1653 (a979bac) into main (2934605) will increase coverage by 19.32%.
The diff coverage is 23.07%.

@@             Coverage Diff             @@
##             main    #1653       +/-   ##
===========================================
+ Coverage   47.58%   66.90%   +19.32%     
===========================================
  Files          77       88       +11     
  Lines        8043     8809      +766     
===========================================
+ Hits         3827     5894     +2067     
+ Misses       3852     2218     -1634     
- Partials      364      697      +333     
Flag Coverage Δ
e2etests 48.92% <23.07%> (?)
unittests 47.58% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/api/entries.go 65.07% <23.07%> (+65.07%) ⬆️

... and 60 files with indirect coverage changes

@bobcallaway bobcallaway merged commit 4c6df3e into sigstore:main Aug 29, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transient errors calling out to trillian should return 503 errors to clients
2 participants