Update .ko.yaml #1682
Update .ko.yaml #1682
Conversation
Use debian12 base image Signed-off-by: Appu <appu@google.com>
|
cc: @jku |
Codecov Report
@@ Coverage Diff @@
## main #1682 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 88 88
Lines 8850 8850
=======================================
Hits 5916 5916
Misses 2231 2231
Partials 703 703
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
I don't believe libssl is needed, as golang implements its own crypto and we don't use boringssl. |
|
Let's switch to static since we shouldn't need anything else. |
.ko.yaml
Outdated
| @@ -14,7 +14,7 @@ | |||
| # limitations under the License. | |||
|
|
|||
| # We need a shell for a lot of redirection/piping to work | |||
| defaultBaseImage: gcr.io/distroless/base:debug-nonroot | |||
| defaultBaseImage: gcr.io/distroless/base-debian12:debug-nonroot | |||
There was a problem hiding this comment.
gcr.io/distroless/static-debian12:nonroot I think should work? We shouldn't need a shell.
There was a problem hiding this comment.
What about the comment above?
If the shell was only needed when entering the it for debugging, I imagine the comment would mention that instead... Is the comment obsolete?
There was a problem hiding this comment.
good point, lemme test this locally. I’m not sure what is using the shell, any guesses @bobcallaway?
There was a problem hiding this comment.
@cpanato maybe knows?
There was a problem hiding this comment.
Using this as the base image, seems like everything is working - I can start the log, upload and fetch an entry.
Maybe the CLI needs a shell? Then we could just specify different base images if so.
There was a problem hiding this comment.
this is a copypasta job from cosign: sigstore/cosign@8974bdc
There was a problem hiding this comment.
OK, I'll follow up on the Cosign thread to double check if we need the shell. Just updated the base image, PTAL
Signed-off-by: Hayden B <hblauzvern@google.com>
Use debian12 base image
Open questions?
base-nossl-debian12:debug-nonroot