Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable GCP cloud profiling on rekor-server #1746

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

bobcallaway
Copy link
Member

enables profiling data to be captured when running rekor-server in GCP

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner October 9, 2023 12:21
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #1746 (229a8b3) into main (75774ff) will decrease coverage by 0.03%.
Report is 5 commits behind head on main.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   66.76%   66.74%   -0.03%     
==========================================
  Files          88       88              
  Lines        8919     8936      +17     
==========================================
+ Hits         5955     5964       +9     
- Misses       2252     2260       +8     
  Partials      712      712              
Flag Coverage Δ
e2etests 48.51% <35.29%> (-0.03%) ⬇️
unittests 47.69% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/rekor-server/app/root.go 62.85% <100.00%> (+2.25%) ⬆️
cmd/rekor-server/app/serve.go 72.22% <0.00%> (-13.03%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
haydentherapper previously approved these changes Oct 9, 2023
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway merged commit 3998fb5 into sigstore:main Oct 9, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants