Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get artifact hash for an entry #1777

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

haydentherapper
Copy link
Contributor

This can be used to get the entry's artifact hash without requiring unmarshaling the type.

Summary

Release Note

Documentation

This can be used to get the entry's artifact hash without requiring
unmarshaling the type.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1777 (6a86e66) into main (2143e33) will increase coverage by 18.83%.
The diff coverage is 37.50%.

@@             Coverage Diff             @@
##             main    #1777       +/-   ##
===========================================
+ Coverage   47.70%   66.53%   +18.83%     
===========================================
  Files          78       90       +12     
  Lines        8182     9048      +866     
===========================================
+ Hits         3903     6020     +2117     
+ Misses       3902     2298     -1604     
- Partials      377      730      +353     
Flag Coverage Δ
e2etests 48.11% <0.00%> (?)
unittests 47.60% <37.50%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/types/entries.go 52.30% <ø> (+47.69%) ⬆️
pkg/types/test_util.go 0.00% <0.00%> (ø)
pkg/types/alpine/v0.0.1/entry.go 74.08% <40.00%> (+16.46%) ⬆️
pkg/types/cose/v0.0.1/entry.go 69.61% <40.00%> (-0.59%) ⬇️
pkg/types/dsse/v0.0.1/entry.go 72.16% <40.00%> (+14.82%) ⬆️
pkg/types/hashedrekord/v0.0.1/entry.go 74.37% <40.00%> (+14.57%) ⬆️
pkg/types/helm/v0.0.1/entry.go 52.94% <40.00%> (-0.25%) ⬇️
pkg/types/intoto/v0.0.1/entry.go 68.14% <40.00%> (+13.05%) ⬆️
pkg/types/intoto/v0.0.2/entry.go 66.57% <40.00%> (+13.46%) ⬆️
pkg/types/jar/v0.0.1/entry.go 59.83% <40.00%> (+16.24%) ⬆️
... and 4 more

... and 51 files with indirect coverage changes

@bobcallaway bobcallaway merged commit b719942 into sigstore:main Oct 19, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants