add support for sha384 and sha512 to hashedrekord type #1958
Conversation
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
===========================================
+ Coverage 47.62% 66.44% +18.82%
===========================================
Files 92 92
Lines 9197 9207 +10
===========================================
+ Hits 4380 6118 +1738
+ Misses 3941 2345 -1596
+ Partials 876 744 -132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| decoded, err := hex.DecodeString(*hash.Value) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| if err := sigObj.Verify(nil, keyObj, options.WithDigest(decoded)); err != nil { | ||
| if err := sigObj.Verify(nil, keyObj, options.WithDigest(decoded), options.WithCryptoSignerOpts(alg)); err != nil { |
There was a problem hiding this comment.
nit for another file: Should we add a comment that the digest in
Line 87 in fc28ac1
There was a problem hiding this comment.
it is a default, so we should probably add that comment. the WithCryptoSignerOpts() already provides a way to override the algorithm.
There was a problem hiding this comment.
I think I was missing this in my PR #1945 .
|
Closed in deference to #1959 |
Summary
Release Note
Documentation