remove trillian images from release process #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
There was a problem hiding this comment.
there's also some references in
rekor/release/ko-sign-release-images.sh
Line 49 in 63aa08f
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
- Coverage 66.53% 66.48% -0.06%
==========================================
Files 92 92
Lines 9246 9246
==========================================
- Hits 6152 6147 -5
- Misses 2351 2355 +4
- Partials 743 744 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
also note we'll want to update Line 53 in 63aa08f |
Signed-off-by: Bob Callaway <bcallaway@google.com>
yup, i'll do that in a separate PR. |
haydentherapper
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that sigstore/scaffolding#968 has landed and v0.6.16 of scaffolding has been released, we should stop building and publishing trillian as part of rekor releases.