Run e2e tests on mysql and redis index backends #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure both index storage backend paths are functionally tested. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
cmurphy
commented
Apr 12, 2024
| run: ./tests/e2e-test.sh | ||
| env: | ||
| INDEX_BACKEND: redis | ||
| - name: Refactor-e2e mysql index # this will a WIP to move all the tests to respective packages |
There was a problem hiding this comment.
It looks like this refactor was started two years ago and never finished, I'm not sure it's worth duplicating these steps or which step should be preferred.
There was a problem hiding this comment.
this seems reasonable to me at first glance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
===========================================
- Coverage 66.46% 48.92% -17.54%
===========================================
Files 92 80 -12
Lines 9258 6639 -2619
===========================================
- Hits 6153 3248 -2905
- Misses 2359 2987 +628
+ Partials 746 404 -342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bobcallaway
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure both index storage backend paths are functionally tested.
Summary
Release Note
Documentation