Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

part 4: allow signing with multiple TUF format #380

Merged
merged 7 commits into from
Sep 20, 2022
Merged

part 4: allow signing with multiple TUF format #380

merged 7 commits into from
Sep 20, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Sep 16, 2022 •
edited

Signed-off-by: Asra Ali asraa@google.com

  • Allow signing with multiple TUF key formats, exposing a boolean to allow for deprecated Key IDs.
  • Update scripts to add signatures associated to deprecated key IDs signing for root role
  • Simplifies code by removing the SigningAndKey struct: we use a TUF key constructor from a signature.Signer

Fixes #329

Summary

Release Note

Documentation

@asraa
part 4: allow signing with multiple TUF format
44ca60b 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa changed the title part 4: allow signing with multiple TUF format WIP: part 4: allow signing with multiple TUF format Sep 16, 2022
@asraa
test: add testing for getsigningkeyids
796380c 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
scripts: add flag for adding deprecated key IDs for signing script
37fa3ac 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa changed the title WIP: part 4: allow signing with multiple TUF format part 4: allow signing with multiple TUF format Sep 19, 2022
@asraa
lint
945c821 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
update comment TODOs with issue
672c5a0 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa
Copy link
Contributor Author

asraa commented Sep 19, 2022

Ready for review!

@kommendorkapten
Copy link
Member

On all, the PR looks good, waiting for clarification on one comment I had (I'm probably wrong, but just want to be sure).

@asraa
docs: clarify getsignignkeyidsforrole with root
6515dcf 
Signed-off-by: Asra Ali <asraa@google.com>
kommendorkapten
kommendorkapten previously approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlorenc
dlorenc previously approved these changes Sep 20, 2022
View reviewed changes
joshuagl
joshuagl previously approved these changes Sep 20, 2022
View reviewed changes
cmd/tuf/app/add-delegation.go Show resolved Hide resolved
cmd/tuf/app/sign.go Outdated Show resolved Hide resolved
haydentherapper
haydentherapper reviewed Sep 20, 2022
View reviewed changes
pkg/repo/repo.go Outdated Show resolved Hide resolved
@asraa
address comments
6386564 
Signed-off-by: Asra Ali <asraa@google.com>
@asraa asraa mentioned this pull request Sep 20, 2022
Open
@asraa
Copy link
Contributor Author

asraa commented Sep 20, 2022

Thank you all!

@asraa asraa merged commit d367c90 into sigstore:main Sep 20, 2022
@asraa asraa mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydentherapper haydentherapper haydentherapper approved these changes

@joshuagl joshuagl joshuagl approved these changes

@dlorenc dlorenc dlorenc left review comments

@kommendorkapten kommendorkapten kommendorkapten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: python-tuf incompatibility because of hex-encoded ECDSA keys
5 participants
@asraa @kommendorkapten @dlorenc @haydentherapper @joshuagl