Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove staged subfolder #783

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Apr 5, 2023

  • Manually removes the staged/ subfolder of the repository.

This is an artifact of the workflow, see #782 for details. It does not affect pre-prod or prod bucket states.

Summary

Release Note

Documentation

Signed-off-by: Asra Ali <asraa@google.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh just posted about this!

@haydentherapper
Copy link
Contributor

haydentherapper commented Apr 5, 2023

What about the POP? As in, is this in any other place?

@asraa
Copy link
Contributor Author

asraa commented Apr 5, 2023

Not in any other place, but the POP has already been removed from the repository subfolder.
#776

@asraa asraa enabled auto-merge (squash) April 5, 2023 15:32
@haydentherapper
Copy link
Contributor

Just wanted to check removing it here is intentional! So we will recreate the POP later on and store it elsewhere I assume?

@asraa
Copy link
Contributor Author

asraa commented Apr 5, 2023

Just wanted to check removing it here is intentional! So we will recreate the POP later on and store it elsewhere I assume?

Hmmmmmmmm... I'm not sure I totally understand - the POP was already verified when the delegation was merged as a PR into this repository - it doesn't belong in the TUF repo itself. The history of it is in the PRs though.

@asraa
Copy link
Contributor Author

asraa commented Apr 5, 2023

You may want to comment on this: #775

If we solve it with option (2) from that, then it can stay in a subfolder "delegation_pops" adjacent to the TUF repo, like we do with keys holding the HSM cert info.

@asraa asraa merged commit c4558e9 into sigstore:main Apr 5, 2023
@haydentherapper
Copy link
Contributor

Ah, I was thinking the POP would be checked periodically so it'd need to be persisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants