Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up terraform for post-install modules #814

Merged

Conversation

bobcallaway
Copy link
Member

A few changes:

  • Remove providers that are not referenced in the module(s)
  • Relax constraints to allow upgrades
  • Upgrades hashicorp/helm provder to latest (kubectl provider is already at latest)
  • Remove label from trillian_namespace, as the helm-chart we use does not specify this and argocd reverts it immediately after terraform applies the change, and then we constantly get an "update in-place" message while running terraform plan

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@bobcallaway bobcallaway merged commit 1e0d22c into sigstore:main Nov 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants