Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change write correctness counter to be a delta #888

Merged
merged 1 commit into from Dec 5, 2023
Merged

Change write correctness counter to be a delta #888

merged 1 commit into from Dec 5, 2023

Conversation

evankanderson
Copy link
Member

@evankanderson evankanderson commented Dec 5, 2023 •
edited

Summary

  • Update the "API Prober: Rekor write correctness verifier returned 'false' within the last 60s" alert to use a delta, so that when the errors stop happening, the alert stops happening.

Release Note

  • Change "API Prober: Rekor write correctness verifier returned 'false' within the last 60s" to only trigger when new errors occur.

Documentation

No need for a docs change.

@evankanderson
Change write correctness counter to be a delta
a1937fd 
Signed-off-by: Evan Anderson <evan@stacklok.com>
@evankanderson evankanderson marked this pull request as ready for review December 5, 2023 19:42
@pwelch pwelch merged commit 279dd4a into sigstore:main Dec 5, 2023
9 checks passed
@evankanderson evankanderson mentioned this pull request Dec 5, 2023
Closed
evankanderson added a commit to evankanderson/scaffolding that referenced this pull request Dec 5, 2023
@evankanderson
Revert "Change write correctness counter to be a delta (sigstore#888)"
1064e1a 
This reverts commit 279dd4a.
@evankanderson evankanderson mentioned this pull request Dec 5, 2023
Merged
evankanderson added a commit to evankanderson/scaffolding that referenced this pull request Dec 5, 2023
@evankanderson
Revert "Change write correctness counter to be a delta (sigstore#888)"
d40eae4 
This reverts commit 279dd4a.

Signed-off-by: Evan Anderson <evan@stacklok.com>
hectorj2f pushed a commit that referenced this pull request Dec 5, 2023
@evankanderson
Revert "Change write correctness counter to be a delta (#888)" (#890)
a8a1d4e 
This reverts commit 279dd4a.

Signed-off-by: Evan Anderson <evan@stacklok.com>
@evankanderson evankanderson mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codysoyland codysoyland codysoyland approved these changes

@pwelch pwelch pwelch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evankanderson @codysoyland @pwelch