Allow multiple artifacts to exist #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to publish the token in GitHub Pages soon. The only realistic way to do that is to use actions/upload-pages-artifact and then actions/deploy-pages -- the currently uploaded artifact is not usable for this. This commit makes the script not fail if there are multiple artifacts, but still uses the same artifact as before. This makes it possible to start publishing a new 'github-pages' artifact without immediately breaking this script. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
I have not actually run the tests locally yet, still figuring this out |
|
I have failed to create a fine-grained token that would work for
|
woodruffw
reviewed
Oct 5, 2023
woodruffw
previously approved these changes
Oct 5, 2023
|
ah looks like I missed a signed-off-by |
If you're feeling lazy, I can override it in a moment 🙂 (since it all gets squashed down anyways) |
woodruffw
approved these changes
Oct 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This relates to sigstore-conformance/extremely-dangerous-public-oidc-beacon#5
I'm planning to publish the (extremely-dangerous-public-oidc) token in GitHub Pages to make it easier to use. The only realistic way to do that is to use actions/upload-pages-artifact and then actions/deploy-pages -- the currently uploaded artifact is not usable for this.
This commit makes the script not fail if there are multiple OIDC token artifacts, but still uses the same artifact as before. This makes it possible to start publishing a new 'github-pages' artifact without immediately breaking this script.
Release Note
NONE
Documentation
NONE