Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: invoke pytest through python #89

Merged
merged 15 commits into from Jul 25, 2023
Merged

action: invoke pytest through python #89

merged 15 commits into from Jul 25, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jul 13, 2023

This shaves down a few of the layers of indirection in the conformance suite, which will (hopefully) make error messages easier to sift through in the future.

Closes #88.

...still need to figure out output retrieval.

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

Something is making very little sense here: the self-test workflow should be running exactly the same tests as the sigstore-python conformance suite, but this one is failing in all kinds of bizarre ways while the sigstore-python conformance suite is passing cleanly:

https://github.com/sigstore/sigstore-python/actions/runs/5546318376/jobs/10126432814

Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw marked this pull request as ready for review July 13, 2023 18:54
@woodruffw
Copy link
Member Author

This is ready for review, but shouldn't be merged until we do another sigstore-python RC.

@woodruffw woodruffw self-assigned this Jul 13, 2023
@woodruffw woodruffw mentioned this pull request Jul 13, 2023
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

CC @steiza the changes here should fix the CI on #82!

Copy link
Collaborator

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit 0b48b5e into main Jul 25, 2023
3 checks passed
@tetsuo-cpp tetsuo-cpp deleted the ww/better-logging branch July 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing
3 participants