Add Fulcio support to signing #158
Conversation
This involved a bit of a refactor to support MessageSignature and DSSE bundle content. Also, we should probably start adding tests soon. Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
|
This PR is kind of large, and it's likely it'll grow with some more testing. If it would help reviewing, I could separate out the Fulcio addition and the bundle content supporting Message Signature and DSSE Envelope - let me know. |
There was a problem hiding this comment.
I'm good with the size and content of the PR! Was easy to read through and I think tests will be straightforward.
The main comment to discuss is the one about Sign being responsible for both certificate requesting and artifact signing, lemme know your thoughts. I don't think it's a significant change from this PR, mostly about providing an interface to request certificates as an optional step of signing.
Signed-off-by: Zach Steindler <steiza@github.com>
`Content` now clearly owns generating and remembering the hash digest. `Keypair` communicates the hash algorithm to `Content`, and generates the signature. Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
Signed-off-by: Zach Steindler <steiza@github.com>
There was a problem hiding this comment.
Thanks again for all the discussion here! @kommendorkapten any other thoughts?
|
I think this looks good for an incremental PR! I have two comments I would like to see answered before merging. |
…gning Signed-off-by: Zach Steindler <steiza@github.com>
|
Nice work @steiza ! |
Summary
Continuing to work towards #136 with small / incremental diffs.
This involved a bit of a refactor to support MessageSignature and DSSE bundle content.
Also, we should probably start adding signing tests soon.
Release Note
NONE - still no Rekor support or testing via conformance tests or integration tests with mocks
Documentation
NONE