Skip to content

Commit

Permalink
Fix reacting to removed published artifacts
Browse files Browse the repository at this point in the history
Only handle them when they are artifacts sigstore created a signature for.

Fixes #414

Signed-off-by: Louis Jacomet <louis@gradle.com>
  • Loading branch information
ljacomet authored and vlsi committed Apr 6, 2023
1 parent e1b8824 commit 8fb89b6
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,18 @@ abstract class SigstoreSignExtension(private val project: Project) {
}
publication.whenPublishableArtifactRemoved {
val publishableArtifact = this
// Ignore artifacts that we have not added a signature for
val artifact = artifacts.remove(publishableArtifact) ?: return@whenPublishableArtifactRemoved
signTask.configure {
signatures.findByName(file.name)
?.takeIf { publishableArtifact in it.builtBy }
signatures.findByName(publishableArtifact.file.name)
?.takeIf { publishableArtifact in it.builtBy }
?.let {
signatures.remove(it)
return@configure
}
// Slow path just in case
signatures.removeIf { publishableArtifact in it.builtBy }
}
val artifact = artifacts.remove(publishableArtifact)
publication.removeDerivedArtifact(artifact)
}
}
Expand Down

0 comments on commit 8fb89b6

Please sign in to comment.