Updates before applying tuf to fulcio client #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loosebazooka
commented
Aug 18, 2023
loosebazooka
commented
- iterate over collection types
- allow appending to certpaths
- managed channels from string targets
- create trust roots directly on CA object
- private key conversion
- iterate over collection types - allow appending to certpaths - managed channels from string targets - create trust roots directly on CA object - private key conversion Signed-off-by: Appu Goundan <appu@google.com>
loosebazooka
commented
Aug 18, 2023
| @@ -135,4 +136,16 @@ public static CertPath toCertPath(Certificate certificate) throws CertificateExc | |||
| CertificateFactory cf = CertificateFactory.getInstance("X.509"); | |||
| return cf.generateCertPath(Collections.singletonList(certificate)); | |||
| } | |||
|
|
|||
| /** Appends an X509Certificate to a {@link CertPath} as a leaf. */ | |||
| public static CertPath appendCertPath(CertPath root, Certificate certificate) | |||
There was a problem hiding this comment.
this is so we can recreate cert paths from provided certificates
| * @param httpParams the http configuration | ||
| * @return a reusable grpc channel | ||
| */ | ||
| public static ManagedChannel newManagedChannel(String serverUrl, HttpParams httpParams) { |
There was a problem hiding this comment.
when we extract the "authority" from a uri (Strip the "http...") it returns a string, so we're going to greate managed channels with a string.
vlsi
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.