Inclusion proof is required #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes inclusion proof on entry.verification not optional. Verification of an entry implies the inclusion proof will also be verified. Rework the code a bit to reflect this and update tests. Signed-off-by: Appu Goundan <appu@google.com>
patflynn
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes inclusion proof on entry.verification not optional.
Verification of an entry implies the inclusion proof will also be verified.
Rework the code a bit to reflect this and update tests.
Why?
Inclusion proof being optional was a function of rekor initially not providing an inclusion proof when an entry was inserted into the log. Now, at insertion time, the returned entry contains a proof.
Consequences?
v1 bundles generated without an inclusion proof will fail to verify.