Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buildinfo at compile time #728

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Add buildinfo at compile time #728

merged 2 commits into from
Jun 18, 2024

Conversation

loosebazooka
Copy link
Member

Injects build info, which appears to be somewhat more portable that reading the jar manifest?

@loosebazooka loosebazooka requested a review from vlsi June 4, 2024 19:11
@vlsi
Copy link
Collaborator

vlsi commented Jun 17, 2024

Ideally, there should be a dependency from compileJava on generateBuildInfo so we know the file is properly generated before compile.

@loosebazooka
Copy link
Member Author

Ideally, there should be a dependency from compileJava on generateBuildInfo so we know the file is properly generated before compile.

I believe this is implicit with the sourceSet

$ ~/src/sigstore-java$ ./gradlew sigstore-java:compileJava --dry-run
:sigstore-java:generateBuildInfo SKIPPED
:sigstore-java:extractProto SKIPPED
:sigstore-java:processResources SKIPPED
:sigstore-java:extractTestProto SKIPPED
:sigstore-java:processTestResources SKIPPED
:sigstore-java:generateJsonSchema2DataClassConfigRekor SKIPPED
:sigstore-java:generateJsonSchema2DataClass SKIPPED
:sigstore-java:extractIncludeProto SKIPPED
:sigstore-java:generateProto SKIPPED
:sigstore-java:compileJava SKIPPED

vlsi
vlsi previously approved these changes Jun 18, 2024
View reviewed changes
@loosebazooka
Add buildinfo at compile time
3fbb763 
Signed-off-by: Appu Goundan <appu@google.com>
vlsi
vlsi previously approved these changes Jun 18, 2024
View reviewed changes
@loosebazooka @vlsi
Update build-logic/jvm/src/main/kotlin/buildlogic/BuildInfoTask.kt
c891d90 
Co-authored-by: Vladimir Sitnikov <sitnikov.vladimir@gmail.com>
Signed-off-by: Appu <appu@google.com>
@loosebazooka loosebazooka merged commit 4e7f805 into main Jun 18, 2024
18 checks passed
@loosebazooka loosebazooka deleted the build-info branch June 18, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlsi vlsi vlsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loosebazooka @vlsi