Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split prod/staging conformance test jobs #1157

Merged
merged 2 commits into from
May 16, 2024
Merged

split prod/staging conformance test jobs #1157

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8da16d
split prod/staging conformance test jobs
bdehamer May 10, 2024
8b06566
Merge branch 'main' into bdehamer/conformance
bdehamer May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/conformance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ permissions:
contents: read

jobs:
conformance:
conformance-production:
name: Conformance Test (Production)
runs-on: ubuntu-latest
steps:
- name: Checkout source
Expand All @@ -29,6 +30,22 @@ jobs:
with:
entrypoint: ${{ github.workspace }}/packages/conformance/bin/run
xfail: "test_verify_with_trust_root"

conformance-staging:
name: Conformance Test (Staging)
runs-on: ubuntu-latest
steps:
- name: Checkout source
uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
- name: Setup node
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
node-version: 18
cache: npm
- name: Install dependencies
run: npm ci
- name: Build sigstore-js
run: npm run build
- uses: sigstore/sigstore-conformance@ee4de0e602873beed74cf9e49d5332529fe69bf6 # v0.0.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder should we disable staging for now since it's breaking?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but I kinda wanna leave it here so I know when its working again.

with:
entrypoint: ${{ github.workspace }}/packages/conformance/bin/run
Expand Down