handle docker hub registry name variants #1158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to better handle the various registry names which may be used to prefix Docker Hub-hosted images.
We require that all image names be fully qualified with a registry -- some tools (like the
docker
CLI) will support registry-less names and default to Docker Hub. We DO NOT support that use case but users still have a few different ways they can qualify their Hub-hosted images:The new logic will detect either of the two above cases and translate the API hostname to the officially-recommended value:
registry-1.docker.io
.See: actions/attest-build-provenance#68