bump make-fetch-happen to v13 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7181198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bdehamer
commented
Aug 11, 2023
Comment on lines
+1
to
+6
| --- | ||
| '@sigstore/mock': minor | ||
| '@sigstore/cli': minor | ||
| --- | ||
|
|
||
| Drop node 14 support |
There was a problem hiding this comment.
Since these two packages haven't yet reached a stable 1.0 release, I'm NOT going to treat the node 16 requirement as a major change.
bdehamer
commented
Aug 11, 2023
Comment on lines
-41
to
+42
| return promise | ||
| .promiseAny(providers.map((getToken) => getToken(this.audience))) | ||
| .catch(() => Promise.reject('CI: no tokens available')); | ||
| return Promise.any( | ||
| providers.map((getToken) => getToken(this.audience)) | ||
| ).catch(() => Promise.reject('CI: no tokens available')); |
There was a problem hiding this comment.
Now that we're on Node 16 we can swap our custom promiseAny function for the Promise.any implementation in the standard library.
Signed-off-by: Brian DeHamer <bdehamer@github.com>
Signed-off-by: Brian DeHamer <bdehamer@github.com>
Signed-off-by: Brian DeHamer <bdehamer@github.com>
feelepxyz
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Preparation for the inclusion of
sigstorein the v10 release of the npm CLI.To minimize the number of extra dependencies we bring to the npm CLI integration, we keep our version of the
make-fetch-happenpackage synchronized with the version in use by npm. With their v10 release, npm will move tomake-fetch-happen@13.0.0so we need asigstoreversion which does the same.The move from v11 to v13 of
make-fetch-happenis a MAJOR SEMVER change which drops support for node 14 (EOL'd April 2023). Adopting v13 ofmake-fetch-happeninsigstorewill also trigger a major semver change and necessitates that we also drop support for node 14.The changes here include:
make-fetch-happento v13 in the packages which are dependent on itThere will be a similar change made to the
tuf-jspackage which also depends onmake-fetch-happen.See #523