Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support upload-artifact / download-artifact 4.x #842

Closed
jku opened this issue Dec 18, 2023 · 0 comments · Fixed by #843
Closed

support upload-artifact / download-artifact 4.x #842

jku opened this issue Dec 18, 2023 · 0 comments · Fixed by #843
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Dec 18, 2023 •
edited
Loading

The new upload-artifact / download-artifact releases have changed their API:

  • uploading multiple times with the same name is no longer possible
  • download-artifact 4.0 requires upload-artifact >= 4.0

This breaks the internal upload-coverage action. There might be a fairly simple refactoring that could work here:

  • use unique artifact names for the different coverage runs in upload-artifact calls
  • use download-artifact without a name (so all artifacts are downloaded), move the coverage files to a single directory

I'll try if this works

Related PRs:
@jku jku added the enhancement New feature or request label Dec 18, 2023
jku added a commit to jku/sigstore-python that referenced this issue Dec 18, 2023
@jku
workflows: Only upload once with one name
a0f8630 
upload-artifact 4.x does not support uploading multiple artifacts
with the same name. Avoid doing that in upload-coverage action.

Fixes sigstore#842

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku added a commit to jku/sigstore-python that referenced this issue Dec 18, 2023
@jku
workflows: Only upload once with one name
a05dbef 
upload-artifact 4.x does not support uploading multiple artifacts
with the same name. Avoid doing that in upload-coverage action.

Fixes sigstore#842

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku linked a pull request Dec 18, 2023 that will close this issue
Refactor upload-coverage action #843
Merged
woodruffw added a commit that referenced this issue Dec 19, 2023
@jku @dependabot @woodruffw
Refactor upload-coverage action (#843)
0e33a4e 
* workflows: Only upload once with one name

upload-artifact 4.x does not support uploading multiple artifacts
with the same name. Avoid doing that in upload-coverage action.

Fixes #842

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

* build(deps): bump actions/upload-artifact

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@a8a3f3a...c7d193f)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/upload-artifact from 3.1.3 to 4.0.0

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@a8a3f3a...c7d193f)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump actions/download-artifact from 3.0.2 to 4.0.0

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3.0.2 to 4.0.0.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3.0.2...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* workflows: ci: Use "coverage combine" arguments

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>

---------

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor upload-coverage action jku/sigstore-python
1 participant
@jku