_cli: refactor logging behavior #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #371. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
added a commit
to pypa/pip-audit
that referenced
this pull request
Dec 27, 2022
This is inspired by the refactor in sigstore/sigstore-python#372. Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
tetsuo-cpp
pushed a commit
to pypa/pip-audit
that referenced
this pull request
Dec 28, 2022
* _cli: refactor logging This is inspired by the refactor in sigstore/sigstore-python#372. Signed-off-by: William Woodruff <william@trailofbits.com> * README: update `pip-audit --help` Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
added a commit
to pypa/pip-audit
that referenced
this pull request
Dec 28, 2022
* _cli: refactor logging This is inspired by the refactor in sigstore/sigstore-python#372. Signed-off-by: William Woodruff <william@trailofbits.com> * README: update `pip-audit --help` Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
added a commit
to pypa/pip-audit
that referenced
this pull request
Dec 29, 2022
* pip_audit, test: warn on Python path confusion Closes #450. Signed-off-by: William Woodruff <william@trailofbits.com> * pip_audit, test: refactor check to use VIRTUAL_ENV Signed-off-by: William Woodruff <william@trailofbits.com> * pip_audit: remove commented code Signed-off-by: William Woodruff <william@trailofbits.com> * pip_audit, test: lintage Signed-off-by: William Woodruff <william@trailofbits.com> * CHANGELOG: record changes Signed-off-by: William Woodruff <william@trailofbits.com> * _cache: Remove remaining "Warning" prefix in log line * _cli: refactor logging (#452) * _cli: refactor logging This is inspired by the refactor in sigstore/sigstore-python#372. Signed-off-by: William Woodruff <william@trailofbits.com> * README: update `pip-audit --help` Signed-off-by: William Woodruff <william@trailofbits.com> Signed-off-by: William Woodruff <william@trailofbits.com> * treewide: prep 2.4.11 (#453) Signed-off-by: William Woodruff <william@trailofbits.com> Co-authored-by: Alex Cameron <asc@tetsuo.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
sigstore's logging behavior to the following:SIGSTORE_LOGLEVELnow only affects thesigstore.*logger hierarchy-vis added as an additive option;-vcorresponds toSIGSTORE_LOGLEVEL=debug-vvcorresponds to<root logger>.setLevel("DEBUG")cc @jku
Closes #371.
Signed-off-by: William Woodruff william@trailofbits.com