_cli: add sigstore verify identity
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `sigstore verify identity`, which is aliased (through some `argparse` hackery) back to `sigstore verify`. This allows us to remain compatible with the existing CLI, while also giving us the flexibility we need to extend verification (e.g. `sigstore verify github`). Signed-off-by: William Woodruff <william@trailofbits.com>
|
NB: This PR doesn't add |
|
/gcbrun |
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
|
/gcbrun |
|
Hmm, this doesn't quite work yet: $ sigstore verify README.mdusage: sigstore verify [-h] {identity} ...
sigstore verify: error: argument verify_subcommand: invalid choice: 'README.md' (choose from 'identity') |
Signed-off-by: William Woodruff <william@trailofbits.com>
|
/gcbrun |
Signed-off-by: William Woodruff <william@trailofbits.com>
|
/gcbrun |
Signed-off-by: William Woodruff <william@trailofbits.com>
|
/gcbrun |
|
Confirmed that each of the following work with these changes: $ sigstore sign --staging README.md --overwrite
$ sigstore verify README.md --cert-identity 'william@yossarian.net' --cert-oidc-issuer 'https://github.com/login/oauth' --staging
$ sigstore verify identity README.md --cert-identity 'william@yossarian.net' --cert-oidc-issuer 'https://github.com/login/oauth' --staging |
|
Implementation details: we do a little bit of
|
Signed-off-by: William Woodruff <william@trailofbits.com>
tetsuo-cpp
reviewed
Jan 4, 2023
| for arg in sys.argv[1:]: | ||
| if arg in ["-h", "--help"]: # global help if no subparser | ||
| break | ||
| else: |
There was a problem hiding this comment.
Whoa... how did I not know that this exists.
| # within `sys.argv`. To do that, we get the index of the `verify` | ||
| # subcommand, and insert it directly after it. | ||
| verify_idx = sys.argv.index("verify") | ||
| sys.argv.insert(verify_idx + 1, name) |
There was a problem hiding this comment.
Can we maybe log a warning here? I realise we don't want to make a breaking change but perhaps we can at least mark it as deprecated and slate it for future removal.
There was a problem hiding this comment.
Yeah, a log sounds good. I'll do that in a moment.
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
force-pushed
the
ww/subcommand-refactor
branch
from
a2589d5
to
088714b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
sigstore verify identity, which is aliased (through someargparsehackery) back tosigstore verify.This allows us to remain compatible with the existing CLI, while also giving us the flexibility we need to extend verification (e.g.
sigstore verify github).See #322.
Signed-off-by: William Woodruff william@trailofbits.com