_internal/tuf: Use expired Fulcio certificates too #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expired Fulcio certificates may have been active at signing time: We should include them in the "bundle of certificate chains". Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
Oh, forgot to talk about testing:
|
|
/gcbrun |
di
approved these changes
Jan 5, 2023
Some of our older Edit: Hmm, maybe not. I'll check the |
woodruffw
approved these changes
Jan 5, 2023
|
/gcbrun |
woodruffw
added
safe to test
component:tuf
|
Yeah, I can't find a good asset to test with here -- even the older certificastes I made during testing weren't chained against the "expired" root, but are rather just missing the intermediate CA that was added in ~July. |
|
I didn't look, but I bet you can find an old-enough cert for https://rekor.tlog.dev/?hash=e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 (the shasum of an empty file) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #385
Summary
Currently only "active" Fulcio certificates are used when verifying. However, expired Fulcio certificates may have been active at signing time: We should include them in the "bundle of certificate chains" that is used during verify.
Release Note