Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Replace ambient credential detection with id #535

Merged
merged 5 commits into from
Mar 9, 2023
Merged

treewide: Replace ambient credential detection with id #535

merged 5 commits into from
Mar 9, 2023

Conversation

tetsuo-cpp
Copy link
Collaborator

Closes #528

@tetsuo-cpp
treewide: Replace ambient credential detection with id
73d4d6f 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
CHANGELOG: Update changelog
bdf9a55 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
README: Amend docs to reflect that we are using id for ambient cred…
a81f2da 
…entials

Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp
README: Wording
5f1f0d8 
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
@tetsuo-cpp tetsuo-cpp added component:signing Core signing functionality dependencies Pull requests that update a dependency file labels Mar 9, 2023
@di di added the safe to test label Mar 9, 2023
woodruffw
woodruffw approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This always makes me happy:

Screenshot 2023-03-09 at 9 57 49 AM

@woodruffw woodruffw merged commit b3fee1f into main Mar 9, 2023
@woodruffw woodruffw deleted the alex/id-credential-detection branch March 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

@tetsuo-cpp tetsuo-cpp

Labels
component:signing Core signing functionality dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace our ambient credential detection with id
3 participants
@tetsuo-cpp @woodruffw @di