Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sct, keyring: specialize errors #555

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Mar 15, 2023

Summary

See #547, #543.

In the SCT module, we now distinguish between the following kinds of verification errors:

  • Invalid (potentially malicious) input signatures,
  • Invalid key ID,
  • Malformed input or API misuse.

Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown self-assigned this Mar 15, 2023
@tnytown tnytown requested a review from woodruffw March 15, 2023 20:37
Signed-off-by: Andrew Pan <a@tny.town>
@woodruffw
Copy link
Member

+@tetsuo-cpp for review 🙂

Signed-off-by: Andrew Pan <a@tny.town>
tetsuo-cpp
tetsuo-cpp previously approved these changes Mar 17, 2023
Copy link
Collaborator

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left one style related question but if you have a good reason for doing this, feel free to merge as is.

Signed-off-by: Andrew Pan <a@tny.town>
@tetsuo-cpp tetsuo-cpp merged commit dddbf4e into sigstore:main Mar 17, 2023
@woodruffw woodruffw deleted the andrew/issue/547 branch March 17, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Public APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants