Adapt ambient OIDC tests to support interactive flow for local testing #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
reviewed
Mar 22, 2023
Makefile
Outdated
Comment on lines
86
to
90
| .PHONY: test-oidc | ||
| test-oidc: TEST_ENV += \ | ||
| SIGSTORE_IDENTITY_TOKEN_production=$$($(MAKE) -s run ARGS="get-identity-token") \ | ||
| SIGSTORE_IDENTITY_TOKEN_staging=$$($(MAKE) -s run ARGS="--staging get-identity-token") | ||
| test-oidc: test |
There was a problem hiding this comment.
Nit: Let's name this test-interactive, to emphasize that it'll require user interaction.
woodruffw
reviewed
Mar 22, 2023
Comment on lines
-128
to
+134
| print("Waiting for browser interaction...") | ||
| print("Waiting for browser interaction...", file=sys.stderr) | ||
| else: | ||
| server.enable_oob() | ||
| print( | ||
| f"Go to the following link in a browser:\n\n\t{server.auth_endpoint}" | ||
| f"Go to the following link in a browser:\n\n\t{server.auth_endpoint}", | ||
| file=sys.stderr, |
|
Let's also document this new |
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
previously approved these changes
Mar 23, 2023
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new Makefile target
test-oidc. This runs ambient OIDC tests with tokens fromsigstore get-identity-token.Partially fixes #570.