Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_cli: implement --output-directory #627

Merged
merged 9 commits into from
Apr 25, 2023
Merged

_cli: implement --output-directory #627

merged 9 commits into from
Apr 25, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Apr 23, 2023

Fixes #620.

@tnytown
_cli: implement --output-directory
7ebbbf2 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown
CHANGELOG: doc
6c76983 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown requested a review from woodruffw April 23, 2023 20:01
@tnytown
CHANGELOG: backfill link for 525
c14e06f 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown added enhancement New feature or request component:cli CLI components safe to test labels Apr 23, 2023
@tnytown tnytown self-assigned this Apr 23, 2023
@tnytown
_cli: create output directory if it does not exist
fb560da 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown
README: update sigstore sign helptext
aa19fb4 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown
_cli: reformat
894c931 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown
README: --output-directory in arg list
0c7b24e 
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
woodruffw approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw enabled auto-merge (squash) April 25, 2023 23:18
@woodruffw woodruffw merged commit 5806c16 into sigstore:main Apr 25, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees

@tnytown tnytown

Labels
component:cli CLI components enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sigstore sign: --output-directory or similar option for writing all outputs to a single directory?
2 participants
@tnytown @woodruffw