New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VerificationMaterials.to_bundle() #719
Add VerificationMaterials.to_bundle() #719
Conversation
Nope, I don't think so -- it'll be auto-generated. |
Signed-off-by: Seth Michael Larson <seth@python.org>
0ea3e49
to
feaf92b
Compare
@woodruffw Implemented your comments. I force pushed because I needed to add a |
Thanks, LGTM! I think this just needs a CHANGELOG entry and then we're good to go. |
/gcbrun |
Lintage:
|
Signed-off-by: Seth Michael Larson <seth@python.org>
/gcbrun |
Signed-off-by: Seth Michael Larson <seth@python.org>
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @sethmlarson!
Were you planning on adding a CHANGELOG
entry? If not, I can add one in a bit.
@woodruffw If you could add one that'd be appreciated, I couldn't immediately figure out what the right annotation would be :) |
It'd probably be "added" for a new public API surface, just for future reference! But I'll push to your branch. |
Signed-off-by: William Woodruff <william@trailofbits.com>
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm the last pusher so @di or @tetsuo-cpp will need to merge here.
Summary
Part of #718, adds the API to convert
VerificationMaterials
that have a Rekor entry loaded into aBundle
.Release Note
Will add a release note.
Documentation
I don't think this needs a docs update?