Read Fulcio certificate chain as bytes in verify command #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maya Costantini <maya.costantini@protonmail.com>
|
/gcbrun |
|
This might be a good candidate for a conformance test here: https://github.com/sigstore/sigstore-conformance/blob/main/test/test_certificate_verify.py |
woodruffw
previously approved these changes
Oct 17, 2023
|
Thanks @mayaCostantini! Would you mind adding a fix |
mayaCostantini
force-pushed
the
cert-chain-bytes
branch
from
f7905d5
to
e221612
Compare
|
Done, thanks! |
Signed-off-by: Maya Costantini <maya.costantini@protonmail.com>
mayaCostantini
force-pushed
the
cert-chain-bytes
branch
from
e221612
to
7ae9f06
Compare
|
/gcbrun |
woodruffw
reviewed
Oct 17, 2023
Signed-off-by: William Woodruff <william@yossarian.net>
|
/gcbrun |
woodruffw
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
LGTM, thanks @mayaCostantini!
@di will have to app and merge since I made a CHANGELOG tweak.
di
approved these changes
Oct 17, 2023
Merged
mayaCostantini
pushed a commit
to mayaCostantini/ansible-sign
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #795
Fix opening the PEM file argument of the
--certificate-chainoption insigstore verify <identity, github>asbytesinstead ofstr.Release Note
None