sigstore: v3 bundles #901
Merged
sigstore: v3 bundles #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Not added until 3.11; use (str, Enum) instead. Signed-off-by: William Woodruff <william@trailofbits.com>
`in` doesn't work on inner enum types until 3.12. Signed-off-by: William Woodruff <william@trailofbits.com>
|
I think this is good to go. It adds support for verifying v3 bundles, but still emits v2 ones. In terms of switching signing to v3: I think the 3.x release series would be reasonable. |
jku
reviewed
Feb 15, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
jku
previously approved these changes
Feb 15, 2024
Yeah, I like that 🙂 -- I'll make a quick change (and also update the CHANGELOG). |
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
jku
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps
sigstore-protobuf-specs, giving us access to the latest Bundle version.