sigstore: flatten models into sigstore.models #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
jku
previously approved these changes
Apr 29, 2024
|
Marking for auto-merge; currently blocking on staging instability. |
* sigstore: extract LogEntry conversions to their own functions Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com> * test: add test for roundtrip LogEntry conversion Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com> * sigstore,test: deduce LogEntry type from its body Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com> * Update sigstore/models.py Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: Facundo Tuesca <facu@tuesca.com> * Update sigstore/models.py Co-authored-by: William Woodruff <william@yossarian.net> Signed-off-by: Facundo Tuesca <facu@tuesca.com> --------- Signed-off-by: Facundo Tuesca <facundo.tuesca@trailofbits.com> Signed-off-by: Facundo Tuesca <facu@tuesca.com> Co-authored-by: William Woodruff <william@yossarian.net>
jku
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #940. Closes #989.
This centralizes a good chunk of our (public) data models into
sigstore.models. It also removes some re-export handling that causes unnecessary import circularity.CC @facutuesca