Upgrade go.mod files to Go 1.20 #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calvin Figuereo-Supraner <mail@calvin.page>
haydentherapper
requested changes
Mar 31, 2023
|
@haydentherapper fair enough, thanks. |
cpanato
reviewed
Mar 31, 2023
hack/tools/go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/sigstore/sigstore/hack/tools | |||
|
|
|||
| go 1.17 | |||
| go 1.20 | |||
There was a problem hiding this comment.
i think here we can bump to go1.20 with no problem
cpanato
reviewed
Mar 31, 2023
test/fuzz/go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/sigstore/sigstore/test/fuzz | |||
|
|
|||
| go 1.18 | |||
| go 1.20 | |||
cpanato
requested changes
Mar 31, 2023
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/sigstore/sigstore | |||
|
|
|||
| go 1.18 | |||
| go 1.20 | |||
There was a problem hiding this comment.
echoing @haydentherapper and this means the minimum required version to build this project
I would keep this as is for now and maybe we bump to go1.19 in a near future
Signed-off-by: Calvin Figuereo-Supraner <mail@calvin.page>
|
I reverted the top-level |
|
sgtm to me as well @haydentherapper |
Signed-off-by: Calvin Figuereo-Supraner <mail@calvin.page>
|
All |
haydentherapper
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1063:
Go 1.18 was released ~a year ago; this PR brings Sigstore onto the latest stable version of Go.
I tested this PR against
maketargets. E2E tests, linting, etc. succeed.Release Note
Upgraded module go directives to Go 1.20.
Documentation
I linked the wrong repo below; I haven't identified any documentation changes needed.
I think this only requires one update:- https://docs.sigstore.dev/cosign/installation/#with-go-119 should readWith Go 1.20I checked by searching "1.17", "1.18", "1.19", and "1.20" in the sigstore/docs repo.