Add support for additional Azure clouds (bug fix), add optional integration test #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
malancas
changed the title
malancas
commented
Jul 14, 2023
bobcallaway
reviewed
Jul 16, 2023
Signed-off-by: Meredith Lancaster <malancas@github.com>
bobcallaway
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request address bugs reported in sigstore/cosign#3094 and sigstore/cosign#3095. It adds supports for the US Government cloud and China cloud. Previously the client would always default to using the public cloud. The client now looks for the
AZURE_ENVIRONMENTenvironment variable to set the cloud. The underlying Azure SDK used by the client before #1170 was merged used this environment variable. Dropping support for this environment variable may be part of the cause for the bugs above.This pull request also adds optional integration tests. This file is meant to be run locally by Azure client developers using an Azure subscription of their choice. Because Sigstore does not use Azure for its infrastructure, this file is not run in any CI/CD.
Release Note
Documentation