update lint action #155
Merged
update lint action #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorj2f
previously approved these changes
Nov 23, 2021
.github/workflows/verify.yml
Outdated
| @@ -44,9 +44,9 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v2.4.0 | |||
| - name: deps | |||
| run: sudo apt-get update && sudo apt-get install -yq libpcsclite-dev | |||
| run: sudo apt-get update | |||
There was a problem hiding this comment.
Do we even need this?
There was a problem hiding this comment.
I don't believe we ever needed libpcsclite for the linter
There was a problem hiding this comment.
I meant we don't need this sudo apt-get update
There was a problem hiding this comment.
for golangci-lint we dont need apt udpate/upgrades/install
There was a problem hiding this comment.
@cpanato @naveensrinivasan removed, PTAL
Signed-off-by: Jake Sanders <jsand@google.com>
bobcallaway
approved these changes
Nov 28, 2021
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
Use KeyParseError (instead of "help requested" error) when both -key and -kms are omitted. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apt-get updatestepuses: golangci/golangci-lint-action@v2to be consistent w/ the same step incosign