Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: add hack/tools to hold non required dependencies/tools for the project #159

Merged
merged 3 commits into from
Nov 25, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 24, 2021

Summary

  • hack: add hack/tools to hold non required dependencies/tools for the project
    as follow up of Feat : Fuzzing #146 (comment)

  • update aws SDK dependency

Ticket Link

n/a

Release Note

hack: add hack/tools to hold non required dependencies/tools for the project

…project

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
bobcallaway
bobcallaway previously approved these changes Nov 24, 2021
Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need swagger or $(GENSRC) in sigstore/sigstore but I'll clean that up in a separate PR since that was already here.

hack/tools/go.mod Outdated Show resolved Hide resolved
dekkagaijin
dekkagaijin previously approved these changes Nov 24, 2021
@dekkagaijin
Copy link
Member

LGTM, always nice to keep things tidy :)

Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One missing variable but otherwise lgtm

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@bobcallaway bobcallaway merged commit 27b4efe into sigstore:main Nov 25, 2021
@cpanato cpanato deleted the hack branch November 25, 2021 10:17
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
also add tests
fixes sigstore#156

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants