Clean up lint errors #167
Merged
Clean up lint errors #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation to various methods throughout library to remove lint errors. Only functional changes are in KMS, where certain methods and variables were made private where it seemed appropriate. Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
dekkagaijin
approved these changes
Nov 30, 2021
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
previously the roots were hardcoded in TrustedCert() function as fulcio.Roots (and the passed value was usuned), but I assume this is not what was intended. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation to various methods throughout library to remove lint
errors.
The only (minor) functional changes are in KMS, where certain methods and variables
were made private where it seemed appropriate and unused methods were removed.
Signed-off-by: Bob Callaway bob.callaway@gmail.com
Summary
Ticket Link
Fixes #154
Release Note