Drop SHA1, SHA224 for RSA-PSS/PKCS#1, enforce for RSA-PKCS#1 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the set of supported hashes to SHA256, SHA384, and SHA512. SHA1 should not be used for RSA-PKCS#1v1.5, as it is not collision resistant. Not an expert on this, but technically SHA1 is acceptable for RSA-PSS due to how the hash function is used, as part of its "mask generation function". However, since SHA1 is not supported by cloud KMS services, we should just remove it entirely. SHA224 is also not supported anywhere. RSA-PKCS#1v1.5 was not enforcing the set of hashes on load. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
|
cc @lukehinds - Can you kick off the workflows? |
|
cc @bobcallaway too, are you able to kick off the workflows? |
dlorenc
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the set of supported hashes to SHA256, SHA384,
and SHA512. SHA1 should not be used for RSA-PKCS#1v1.5,
as it is not collision resistant. Not an expert on this,
but technically SHA1 is acceptable for RSA-PSS due to how
the hash function is used, as part of its
"mask generation function". However, since SHA1 is not
supported by cloud KMS services, we should just remove it entirely.
SHA224 is also not supported anywhere.
RSA-PKCS#1v1.5 was not enforcing the set of hashes on load.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note