Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable gofumpt with extra #278

Merged
merged 2 commits into from
Jul 29, 2022
Merged

ci: enable gofumpt with extra #278

merged 2 commits into from
Jul 29, 2022

Conversation

Dentrax
Copy link
Member

@Dentrax Dentrax commented Feb 17, 2022

Signed-off-by: Furkan furkan.turkal@trendyol.com

Ran $ gofumpt -w -extra .

-w	write result to (source) file instead of stdout
-extra
    	enable extra rules which should be vetted by a human

Summary

Ticket Link

Fixes

Release Note


@dlorenc
Copy link
Member

dlorenc commented Feb 21, 2022

Looks like this has a new lint issue caused by the change!

@cpanato
Copy link
Member

cpanato commented Apr 8, 2022

hello, any updates on this PR? thanks!

@Dentrax
Copy link
Member Author

Dentrax commented May 10, 2022

Can someone please approve? Thanks!

@cpanato
Copy link
Member

cpanato commented May 10, 2022

@Dentrax you need to rebase and fix the conflicts :)

@Dentrax
Copy link
Member Author

Dentrax commented May 10, 2022

Missed that! Rebased.

cpanato
cpanato previously approved these changes May 10, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato requested a review from dlorenc May 10, 2022 08:14
@cpanato
Copy link
Member

cpanato commented May 12, 2022

@Dentrax can you please rebase? just to get the latest from the main branch? thanks

@cpanato
Copy link
Member

cpanato commented Jul 28, 2022

need a new rebase 😓

dekkagaijin
dekkagaijin previously approved these changes Jul 28, 2022
@cpanato
Copy link
Member

cpanato commented Jul 29, 2022

i will do a rebase to we get this merged

Signed-off-by: Furkan <furkan.turkal@trendyol.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@dlorenc dlorenc merged commit f3ef3e6 into sigstore:main Jul 29, 2022
mtrmac pushed a commit to mtrmac/sigstore that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants