return immediately, without waiting for the operation in progress to complete #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complete Signed-off-by: cpanato <ctadeu@gmail.com>
dlorenc
approved these changes
Mar 14, 2022
lukehinds
reviewed
Mar 14, 2022
|
opps, I missed it. |
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
…tore#326) Bumps [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) from 0.5.0 to 0.5.1. - [Release notes](https://github.com/google/go-containerregistry/releases) - [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml) - [Commits](google/go-containerregistry@v0.5.0...v0.5.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
we should not stream the logs from the cloudbuild to the GitHub action job to avoid any possible leaks.
so after the job is submitted it returns and completes the task
related to https://github.com/sigstore/fulcio/runs/5536478096?check_suite_focus=true the cloudbuild ran successfully but the svc account does not have permission to stream the logs, and then it failed.
Ticket Link
n/a
Release Note