Add fake signer that implements KMS interface #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bobcallaway |
hectorj2f
previously approved these changes
Mar 31, 2022
This allows us to test code that uses kms.Get by importing the fake KMS package. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dlorenc
previously approved these changes
Mar 31, 2022
|
Need to make one quick change before this is submitted, I want to provide a way to pass in a private key to the loader. Otherwise if you call kms.Get() repeatedly, you'll get back different key values each time. |
|
Added: A bit of a weird way to do it, but I'm passing a marshalled ECDSA private key via the string ref. If the string ref after |
|
You know what, it'd be far easier to just pass the private key in the context. I'll clean this up. |
haydentherapper
force-pushed
the
fake
branch
2 times, most recently
from
60cee30
to
f0d31ea
Compare
|
Ready for review! |
The private key is passed in the context. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
dlorenc
approved these changes
Apr 1, 2022
mtrmac
pushed a commit
to mtrmac/sigstore
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Jake Sanders <jsand@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to test code that uses kms.Get by importing the fake KMS
package.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Ticket Link
Fixes
Release Note